Re-review: Alternative area display #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d areas in AreaInfo component
…sed on fillColor expression
…n AreaInfo Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
… handling Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
…nd update indicator colors; enhance map color configuration with geography color.
…name compareAreasAtom to compareGeographiesAtom; update related components and hooks for consistency
…ge into useMapControls hook; update related components and hooks for improved clarity and consistency
…rea, and compare geographies modes; streamline state management in MapMarkerAndAreaControls component
…ook; ensure proper state management when toggling edit mode in Map component
…condary data handling and improve event propagation; update useMapHover and usePlacedMarkers hooks for better mode management and cursor behavior
…isplay logic and improve table layout responsiveness
Address code review feedback: fix Tailwind classes, accessibility, and state management
…ate management and error handling during mode changes
… layout consistency
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ener handling in useMapHoverEffect
…and compareGeographiesMode to prevent unnecessary re-renders
Member
|
@copilot he performance of the map decreases a lot when more than say 50 rows of data are visualisaed (for example as a constituencies). |
Contributor
…alculations Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
Co-authored-by: ev-sc <4164774+ev-sc@users.noreply.github.com>
… streamline statLabel assignment
…able useTurfState hook
Optimize hover performance for large datasets (50+ areas)
…rea outlines based on selection state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ev-sc I reverted this merge because after checking it out, I noticed that the performance is noticeably slower:
https://www.loom.com/share/45150cd6a4e84edf8d3db471f0579a2d